#1 Re: general discussion » communication » 2015-12-22 17:31:38

After using the forum for some time, I realized that I really do not find it a convincing solution for communication. I usually follow discussions reading emails during idle time on the phone and with the current solution I just get one message and have to read the rest in the browser. I did not find an option where I could change this behaviour.

Discourse looks pretty good, so +1 from my side for exploring this option further. Using the mailing list would be fine for too, but discourse would probably give a much better experience for the "end user".

#2 Re: general discussion » (No) new project? » 2015-12-20 20:06:58

Hi Olaf,

I don't want to force my map implementation on the official project page at all and also would not want you to abandon your work. I only digged out my map implementation to show you what I could offer and just gained some motivation to update it to a recent OL3 version (unfortunately, many useful parts of OL3 are not stable, yet). Then adding new features was just behind the fence. :)

I will continue the work on my map anyway and will officially put it online somewhere as soon as it leaves the prototype state. So even if the map should not end up here, your feedback is highly welcome. I also do not find the map implementation a super large contribution to the project because in principle it just provides a viewer for the "real" contributions (rendered tiles, offline maps, ...). So I really don't care too much whether the project builds on your code base or mine.

I just would not want to port your implementation to OL3 because that's not much fun for me (in contrast to implementing new features) and there was not much progress in your map during the last months (in mine neither). But since you started porting the map yourself, this is a perfectly fine solution to me. If you can find some solutions for sub-problems in my code, this would be great. My code is not yet labelled as such, but I will officially put it under the GPL in the next few days (maybe only after Christmas), so please take whatever you find useful.

Since both implementations will be freely available, the ONC project can always choose freely which one should be officially on display.

Cheers,
Gabi

PS: I did not want to panic, but a wise man once said "A MB-burnt child dreads the fire."

#3 Re: general discussion » online map » 2015-12-20 07:15:36

Olaf_H wrote:

First of all: This is no new project.

I started a discussion on this topic in a separate thread.

We need to decide what the online map should do. There are a lot of sites only displaying a map everywhere in the web. Do we only want to display another "look at my cool layer collection" solution? I think everyone can do this on his own. We do not need a new project for this. How much more or less usable layers do you want to have? The real goal (rendering our own layers, creating maps for chart plotters and so on) get more and more invisible.

I do not want to wildly collect layers, but I thought that this thread was on what is there and how we should integrate it. This does not mean that we need to integrate everything at the end but adding and removing layers is usually pretty easy, so I do not see a problem in collecting what we have first. In contrast to me, Dirk is more interested into rivers than the sea, so it is only natural that we would like to have to different layers included.

Restricted zoom levels
The weather is only working from z4 to z7 on other zoom levels you will see nothing. If weather is selected, automatically zoom to a feasible level. Otherwise the user will see nothing and gets confused. Also prevent the possibility to zoom into other levels than the allowed ones. If weather is deselected, zoom back to the last used zoom level and position of the base map.

This will probably not only affect the weather layer. My idea was to restrict layers to certain zoom levels and make this transparent to the use (e.g. in the layer selection).

Weather page in general
On the first selection I will not see any weather layer (z6). Need to zoom in and out to get it loading (Firefox on Linux). Do not display all weather layers on the first load. This is confusing (no usable information)

See comment above. Default settings for displaying layers can easily be changed. I see my map in a prototypical state and I did not optimize such aspects, yet.

I do not like the layout. The sidebar is not usable to display large content The icons (with no text) are not intuitive. You need to click around to find the needed information.

I don't like the old layout but as you wrote regarding your map, this is mostly css and can be changed. I think layout is something that should be discussed independently (and maybe in a separate thread).  The sidebar has been inspired by other modern maps (e.g. openstreetmap). It's existence does not mean that there cannot be larger display areas for some content. And it is only a div...

With "as desktop" I mean, that there is no need to have an additional web site for help, information, news and so on. Everything can be displayed using additional dialogs on top of the map, if selected. I have all this features in place. That is why the code base seems to be large regarding to the displayed layers.

I fully agree with you regarding the role of the map as entry page. I do not agree that this is the solemn reason for the size of your code base.

I am missing in your map:
- No cookies for position, zoom and selected layers (later on selected language)
- No internationalization
- No overpass.api query to gather additional information
- No coordinate grid
- No help links and about information
- No map key
- No possibility to load additional html content into dialogs

- Cookies for zoom and position still need to be implemented (which is easy). I expected cookies for selected layers to work. Can you tell me how I can reproduce the unintended behaviour?
- Internationalization: Agreed, that will definitively be necessary
- Overpass: That's what I wanted to integrate first from Dirk's map
- Coordinate grid: With OL3 this is not as easy as with OL2 because there is no layer that provides it including labels. I have an implementation (cf. http://openseamap.he1ix.org/openlayers3/map.html) that I just need to add.
- Help links and about: I did not want to include these before having internationalization in place
- Map key: I am no convinced that hard-coding them into the map is the right way to go. I would first want to inquire whether it is somehow possible to do this in a spirit as it is for example standard with WMS layers (the layer provider provides the key, so that it is guaranteed that map and key stay in sync).
- No possibility to load additional html content into dialogs: Was not necessary so far but should be straight-forward.

#4 general discussion » (No) new project? » 2015-12-20 06:47:51

Gabi
Replies: 6

Hi everyone,

in https://forum.opennauticalchart.org/viewtopic.php?id=6 Dirk started a thread regarding the online map because there are (at least) three code bases, we could build on (by Dirk, Olaf and me).

In https://forum.opennauticalchart.org/vie … pid=48#p48, Olaf wrote that "this is no new project". That's of course right, but from my understanding it was previously mainly run by Olaf.

I left open sea map because I was not happy with Markus' role. So far, Olaf gave me no impression that at ONC Markus' role would just get a new name, but I am still a bit worried and I do not want to intrude or hijack someone's project.

Maybe we should discuss this before everything is settled and fixed.

@Olaf: How do you see this? Do you feel bum-rushed and would prefer if we start a truly new project?

@all: From the OSeaMap mailing list, I have the impression that many of you left OpenSeaMap for similar reasons. As alternative to ONC, I would also be fine with starting entirely new (e.g. as LibreSeaMap). What's your opinion on this?

Cheers,
Gabi

#6 Re: general discussion » online map » 2015-12-19 23:26:32

@Dirk: Wide parts of your map should be super-easy to integrate with mine. Would you mind if I just take over the easy parts and see what remains to give us some head ache?

#7 Re: general discussion » online map » 2015-12-19 23:23:17

I added a layer with German water levels and a basic implementation of the map download to my implementation.

@Olaf:
- I was so bold to copy the xml file with the download map data from your repository. I hope this is ok.
- What do you mean with "the problem of the restricted zoom levels"?
- Could you elaborate a bit on what you mean with "as desktop"? What additional information do you mean?

#8 Re: general discussion » online map » 2015-12-19 17:22:29

In principle, I am fine with building on any code base. I had a look at Olaf's repository and think it would be much more work to port this than adding the additional functionality to my code base.

Some advantages of my code base
- integration of weather map into main map
- more modern design
- so far pure JavaScript
- much fewer code for comparable functionality

Disadvantages:
- no internationalization yet (but straightforward to include)
- Chart download not integrated yet (but Olaf's implementation can easily be ported)

Of course my design is also modular (that was the main reason why I did not build on the OpenStreetMap ol2 implementation).

I restarted a repository with my code (previously it was developed in a subfolder of the OSeaMap online map repository). You can find it at https://github.com/roeger/onlineseamap. Please have a look and let me know what you think. Niko made the current state of the map online available at http://openseamap.he1ix.org/map.html

Dirk is your code somewhere available? I would like to see how easily our code could be merged (I assume quite easily).

I have one or two hours time this evening and plan to reintroduce the German water levels and maybe try to integrate the map download.

Regarding map key (legend): I don't think this should be hard coded in the map implementation but rather be requested from the tile server.

Board footer

Powered by FluxBB